-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SILABS] Adds support for WiFi band details #38051
Merged
mergify
merged 4 commits into
project-chip:master
from
rosahay-silabs:feature/add-wifi-band-support
Mar 20, 2025
Merged
[SILABS] Adds support for WiFi band details #38051
mergify
merged 4 commits into
project-chip:master
from
rosahay-silabs:feature/add-wifi-band-support
Mar 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `WiFiBandEnum` to scan callback struct * Fix typo in variable name for scanned SSID length in BackgroundScanCallback * Add WiFiBandEnum usage to WiFi interface implementations * Add WiFi band information to scan response in SlWiFiDriver * Refactor WiFiBandEnum usage to fully qualify the namespace in WifiInterface.h --------- Co-authored-by: brosahay <3526930+brosahay@users.noreply.github.com>
PR #38051: Size comparison from 52d8e11 to 73964a2 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Mar 18, 2025
andy31415
approved these changes
Mar 20, 2025
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Mar 28, 2025
* Adds `GetSupportedWiFiBandsMask` API * Refactor WiFi band mask methods for consistency in naming * Fix WiFi band enum reference in GetSupportedWiFiBandsMask implementation * Adds support for WiFi band scan results (project-chip#326) * Add `WiFiBandEnum` to scan callback struct * Fix typo in variable name for scanned SSID length in BackgroundScanCallback * Add WiFiBandEnum usage to WiFi interface implementations * Add WiFi band information to scan response in SlWiFiDriver * Refactor WiFiBandEnum usage to fully qualify the namespace in WifiInterface.h --------- Co-authored-by: brosahay <3526930+brosahay@users.noreply.github.com> --------- Co-authored-by: brosahay <3526930+brosahay@users.noreply.github.com>
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Mar 28, 2025
* Adds `GetSupportedWiFiBandsMask` API * Refactor WiFi band mask methods for consistency in naming * Fix WiFi band enum reference in GetSupportedWiFiBandsMask implementation * Adds support for WiFi band scan results (project-chip#326) * Add `WiFiBandEnum` to scan callback struct * Fix typo in variable name for scanned SSID length in BackgroundScanCallback * Add WiFiBandEnum usage to WiFi interface implementations * Add WiFi band information to scan response in SlWiFiDriver * Refactor WiFiBandEnum usage to fully qualify the namespace in WifiInterface.h --------- Co-authored-by: brosahay <3526930+brosahay@users.noreply.github.com> --------- Co-authored-by: brosahay <3526930+brosahay@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Testing
chip-tool networkcommissioning scan-networks $CHIP_NODE_ID 0
Executed the above command to verify results, since value is hardcoded verified that changing that also reflects in the results of
chip-tool
.The device combinations tested:
917 SoC
EFR32 + 917 NCP
EFR32 + WF200